You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
replace the dependency on TagSoup by a dependency on Validator.nu's HTML parser,
replace TagSoup options by Validator.nu options,
use Validator.nu for implementing html:parse,
add function fn:parse-html, based on html:parse (but, in contrast to that, without falling back to the XML parser in case Validator.nu is unavailable).
Some slight restructuring of StandardFunc and FuncOptions was necessary to be able to produce error FODC0012.
The latest changes to this PR re-integrate TagSoup, which remains to be the default HTML parser for everything except fn:parse-html, the latter using Validator.nu as the default.
HtmlOptions integrates the options from both TagSoup and Validator.nu. Both for fn:parse-html, html:parse, and the other users of HtmlParser that supply HtmlOptions, the method option can be used to select the parser to be used. This will be TagSoup for option values xml and html, and Validator.nu for option value nu.
Out of the 1379 QT4-tests for fn:parse-html, 1367 are now passing, and 12 still fail. These still need to be inspected in more detail.
Thanks, was everything fine. Next, we could tackle the options of fn:html-parse and decide which ones we want to support, or which ones we want to discuss in the qtspecs repository. For example, I am not sure whether encoding should be retained, but it could be useful for the still-tobe-added fn:html-doc function.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes
html:parse,fn:parse-html, based onhtml:parse(but, in contrast to that, without falling back to the XML parser in case Validator.nu is unavailable).Some slight restructuring of
StandardFuncandFuncOptionswas necessary to be able to produce errorFODC0012.